0004083: qrand() is deprecated

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0004083

Doomseeker

[All Projects] Cleanup

public

2023-01-04 20:46

2023-02-21 09:27

Reporter

Zalewa

Assigned To

Priority

low

Severity

minor

Reproducibility

N/A

Status

new

Resolution

open

Platform

OS Version

Product Version

1.3.3

Target Version

1.5.0

Fixed in Version

Summary

0004083: qrand() is deprecated

Description

Doomseeker uses qrand() in its refresher code and in the fake plugin. The compiler complains that it's deprecated.

Additional Information

The equivalent replacement seems to be QRandomGenerator::global()->generate(), but QRandomGenerator was added in Qt 5.10. I still need to build against Qt 5.7. We could also use our own Random class which is also a part of the Plugin API.

Attached Files

Relationships

Notes
(0022669) Pol M (developer) 2023-01-05 13:09 edited on: 2023-01-05 13:17	I'd use a xoshiro generator: 'https://prng.di.unimi.it/ [^]' They are trivial to implement, statistically good enough for our use case, and are performant.

(0022676) Zalewa (developer) 2023-01-06 00:08	That's good to know, but I think we'll be fine with the C++ random generator as already used in our Random class.

(0022779) Blzut3 (administrator) 2023-02-21 09:27	Noticed Qt 6 compile was broken, so did a quick work around for that specific scenario (does not resolve this ticket):'https://bitbucket.org/Doomseeker/doomseeker/commits/437631fda5d2e719c5fe2949d91af26441d94d9b [^]'

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	No one explicitly supports this issue yet.
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2023-01-04 20:46	Zalewa	New Issue
2023-01-05 13:09	Pol M	Note Added: 0022669
2023-01-05 13:17	Pol M	Note Edited: 0022669	View Revisions
2023-01-06 00:08	Zalewa	Note Added: 0022676
2023-01-25 22:00	Zalewa	Target Version	=> 1.5.0
2023-02-21 09:27	Blzut3	Note Added: 0022779

Questions or other issues? Contact Us.

Links

Doom and Doom II are the property of id Software.