Anonymous | Login | Signup for a new account | 2024-05-02 21:26 UTC |
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0003398 | Doomseeker | [All Projects] Bug | public | 2018-03-04 11:57 | 2018-10-27 22:53 | ||||
Reporter | WubTheCaptain | ||||||||
Assigned To | Zalewa | ||||||||
Priority | low | Severity | minor | Reproducibility | always | ||||
Status | closed | Resolution | fixed | ||||||
Platform | x86_64 | OS | Debian GNU/Linux | OS Version | buster/sid | ||||
Product Version | 1.1 | ||||||||
Target Version | 1.2 | Fixed in Version | 1.2 | ||||||
Summary | 0003398: Buddies: Square brackets in "Add Buddy" are accepted by basic pattern type but not matching and the pattern is removed on launch | ||||||||
Description | If my ingame name on Zandronum is []Wub then it's impossible to match []Wub with basic pattern type in Doomseeker, yet it's temporarily accepted as a valid pattern but also removed on next launch of Doomseeker. | ||||||||
Steps To Reproduce |
| ||||||||
Additional Information | Ditto in current 1.2~beta-1 (latest source as of time of writing). | ||||||||
Attached Files | |||||||||
Relationships | ||||||
|
Notes | |
(0020102) Zalewa (developer) 2018-10-13 16:47 |
'https://bitbucket.org/Doomseeker/doomseeker/commits/4f87a2e3482f8da1ddca32aad6c2fd6ef4b7913d [^]' The "Add Buddy" dialog box should now reject the invalid patterns outright, no matter if they're basic or advanced. Also, I changed the way in which the patterns are serialized. Qt now deals with serialization of QRegExp objects that constitute the buddy patterns. The value stored in the .ini file is no longer user friendly, but at least we don't need to worry about our homebrewed parser not reading something correctly. |
(0020106) WubTheCaptain (reporter) 2018-10-13 17:54 edited on: 2018-10-13 17:56 |
Buddies added in 1.2 won't be written to config in a backwards compatible way to deprecated pre-1.2 BuddiesList. I suppose this is acceptable. |
(0020108) Zalewa (developer) 2018-10-13 17:56 |
Quote from WubTheCaptain Indeed. |
(0020109) WubTheCaptain (reporter) 2018-10-13 17:57 |
Besides my previous note on backwards compatibility (downgrading software version), I believe this is resolved if Zalewa finds my notion acceptable too. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | No one explicitly supports this issue yet. |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2018-03-04 11:57 | WubTheCaptain | New Issue | |
2018-03-04 11:57 | WubTheCaptain | Additional Information Updated | View Revisions |
2018-03-04 12:05 | WubTheCaptain | Steps to Reproduce Updated | View Revisions |
2018-03-04 12:05 | WubTheCaptain | Summary | Buddies: Brackets in "Add Buddy" are accepted by basic pattern type, but not matching and removed on next launch => Buddies: Square brackets in "Add Buddy" are accepted by basic pattern type, but not matching and removed on next launch |
2018-03-04 12:09 | WubTheCaptain | Summary | Buddies: Square brackets in "Add Buddy" are accepted by basic pattern type, but not matching and removed on next launch => Buddies: Square brackets in "Add Buddy" are accepted by basic pattern type but not matching and the pattern is removed on launch |
2018-03-04 12:21 | WubTheCaptain | Relationship added | child of 0003399 |
2018-10-05 07:22 | WubTheCaptain | Priority | normal => low |
2018-10-13 14:47 | Zalewa | Assigned To | => Zalewa |
2018-10-13 14:47 | Zalewa | Status | new => assigned |
2018-10-13 16:47 | Zalewa | Note Added: 0020102 | |
2018-10-13 16:47 | Zalewa | Status | assigned => needs testing |
2018-10-13 17:00 | WubTheCaptain | Target Version | => 1.2 |
2018-10-13 17:48 | WubTheCaptain | Relationship replaced | parent of 0003399 |
2018-10-13 17:54 | WubTheCaptain | Note Added: 0020106 | |
2018-10-13 17:54 | WubTheCaptain | Status | needs testing => needs review |
2018-10-13 17:56 | WubTheCaptain | Note Edited: 0020106 | View Revisions |
2018-10-13 17:56 | Zalewa | Note Added: 0020108 | |
2018-10-13 17:57 | WubTheCaptain | Note Added: 0020109 | |
2018-10-13 17:57 | WubTheCaptain | Status | needs review => resolved |
2018-10-13 17:57 | WubTheCaptain | Fixed in Version | => 1.2 |
2018-10-13 17:57 | WubTheCaptain | Resolution | open => fixed |
2018-10-27 22:53 | WubTheCaptain | Status | resolved => closed |
Copyright © 2000 - 2024 MantisBT Team |