Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Doomseeker Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003376Doomseeker[All Projects] Bugpublic2018-02-18 18:442018-10-27 22:53
ReporterZalewa 
Assigned ToZalewa 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version 
Target Version1.2Fixed in Version1.2 
Summary0003376: Domain names look ups get the process stuck when quitting during look up.
DescriptionDomain names look ups get the process stuck when quitting during look up.

QHostInfo::lookupHost()

We already have a workaround for this, but a workaround is a workaround and it doesn't solve the same problem when caused by QAbstractSocket::connectToHost().

The proper solution for this is to "delete QApplication" before returning from main().
Steps To Reproduce1. Reverse commit'https://bitbucket.org/Doomseeker/doomseeker/commits/fb1f296bfbcffe767f3c4e6bda16ff9c5f0c6b95 [^]'
2. Look up a domain name that will take long to resolve. Non-existent domain name like "lolcathost" is good for this.
3. During look up, quit Doomseeker.
4. Notice that the process never ends.
Additional InformationMinimal example with explanation when "stuck" happens can be found here:'https://bitbucket.org/zalewa/dotfiles/src/5c2545284971ae6924fd42466041e37d8913336b/dev/qt/hostlookup/?at=default [^]'

See comment in main.cpp, main() function, line 83.
Attached Files

- Relationships
related to 0003287closedZalewa IRC: IRC network address hostname lookups use IPv4 when IPv6 connectivity is available 

-  Notes
User avatar (0019072)
Zalewa (developer)
2018-02-18 19:05

 Two changes, second is indirectly dependent on the first:

1. "delete QApplication instance" added in this commit:'https://bitbucket.org/Doomseeker/doomseeker/commits/3cabc2fba79f3f787e6e46f4c3fdb612b50eb1d5 [^]'

2. LookupHost workaround removed and replaced with proper QHostInfo::lookupHost() here:'https://bitbucket.org/Doomseeker/doomseeker/commits/75080a1a29cb749489dabcbe1ad89a4148d20fce [^]'

Program should be now tested for any case where the process gets stuck running forever on quit.
User avatar (0019822)
WubTheCaptain (reporter)
2018-09-29 15:15

 Not sure if related, but something like described is still experienced on OpenBSD 6.4-current. Needs testing (especially on that operating system), for sure.
User avatar (0019830)
WubTheCaptain (reporter)
2018-09-29 16:10
edited on: 2018-09-29 16:10

 Could this also be related to 0003494?
User avatar (0019851)
Blzut3 (administrator)
2018-10-01 04:13

 This was an hang on exit, I'm not sure how that's related to no traffic being sent?

In any case you an disable the hostname lookups in the options.
User avatar (0019880)
WubTheCaptain (reporter)
2018-10-02 05:47

 Probably still needs to be reviewed/tested why OpenBSD 6.4-current hangs on exit in a virtual machine, but not for intox8907 on bare metal (assumed).
User avatar (0020051)
WubTheCaptain (reporter)
2018-10-09 10:36

 Since OpenBSD has some other weird networking problems with Qt5 and Doomseeker and intox8907 couldn't reproduce the issue, and I can't reproduce the issue in this ticket with Qt 5.11 on Debian GNU/Linux, I guess this is resolved.

I agree the patches by Zalewa are correct.

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: No one explicitly supports this issue yet.
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2018-02-18 18:44 Zalewa New Issue
2018-02-18 18:44 Zalewa Relationship added related to 0003287
2018-02-18 18:44 Zalewa Assigned To => Zalewa
2018-02-18 18:44 Zalewa Status new => assigned
2018-02-18 19:05 Zalewa Note Added: 0019072
2018-02-18 19:05 Zalewa Status assigned => needs testing
2018-09-29 15:14 WubTheCaptain Target Version => 1.2
2018-09-29 15:15 WubTheCaptain Note Added: 0019822
2018-09-29 16:10 WubTheCaptain Note Added: 0019830
2018-09-29 16:10 WubTheCaptain Note Edited: 0019830 View Revisions
2018-10-01 03:37 WubTheCaptain Status needs testing => feedback
2018-10-01 04:13 Blzut3 Note Added: 0019851
2018-10-02 05:47 WubTheCaptain Note Added: 0019880
2018-10-02 05:47 WubTheCaptain Status feedback => needs review
2018-10-02 19:26 Zalewa Assigned To Zalewa =>
2018-10-09 10:36 WubTheCaptain Note Added: 0020051
2018-10-09 10:36 WubTheCaptain Status needs review => resolved
2018-10-09 10:36 WubTheCaptain Fixed in Version => 1.2
2018-10-09 10:36 WubTheCaptain Resolution open => fixed
2018-10-09 10:36 WubTheCaptain Assigned To => Zalewa
2018-10-27 22:53 WubTheCaptain Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker