Zandronum Chat on our Discord Server Get the latest version: 3.1
Source Code
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account
  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0003186Zandronum[All Projects] Bugpublic2017-07-14 00:202018-09-30 22:33
ReporterNinjamander 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionno change required 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target VersionFixed in Version 
Summary0003186: Broken Revival kit in RGA2 in survival/coop
DescriptionAfter testing Real Gun advance (rga2ref_core.wad , rga2ref_code_140.wad , rga2ref_mon_140.wad and rga2ref_blade_140.wad)

I notice the revival kit work perfectly in zandronum 2.1.2 but will result in player dying in 3.x. I suspect is been like this for a while now
Steps To ReproducePlayer A get last stand perk
Player B get last stand pro perk
Player A get shot down and need to get revived
Player B select the revival kit and (shoot) the player with it at melee range

result per version:
2.1.2 Player A get revived and continue on his rampage
3.x Player A either get revived very briefly then die right after or simply die
Additional InformationI do not know what version of 3.x broke this sadly
Attached Files

- Relationships

-  Notes
User avatar (0018022)
Torr Samaho (administrator)
2017-07-14 06:00

 Can somebody condense this to a minimal example?
User avatar (0018023)
Korshun (reporter)
2017-07-14 13:09
edited on: 2017-07-14 13:11

 RGA2 code is way too overcomplicated to reliably reduce it to a minimal example wad.

This bug is present in ALL 3.0 versions (both the latest and 150819-2351), but not in 2.1.2. It is also present on Linux, as it happens on TSPG.

This bug makes the reviving player seem to apply the revive script on himself (judging by the screen flash) instead of on the intended player.

An easy way to test this bug is to do the following:
1. run a server
2. connect and join as "Juggernaut" class
3. connect and join in another instance of Zandronum as "Medic" class
4. as Juggernaut, throw two greandes under your feet
5. as Medic, try to revive the Juggernaut
User avatar (0018028)
jdagenet (reporter)
2017-07-14 19:12

 The issue seems to be the morphing flag "MRF_LOSEACTUALWEAPON", though I'm not sure if the flag is broken or if the mod wasn't built with that flag in mind.

Torr, was that flag present in 2.1.2?
User avatar (0018029)
Korshun (reporter)
2017-07-14 21:16
edited on: 2017-07-14 21:17

 This bug is caused by script 625 getting called immediately after successful revive. It is not called after reviving in 2.1.2.

It is also most likely unrelated to morph flags.
User avatar (0018030)
jdagenet (reporter)
2017-07-14 21:39
edited on: 2017-07-14 21:41

 It is related to the morphing flags. If you don't pass any flags when the player is sent to last stand then he doesn't die if someone tries to revive him.
User avatar (0018032)
Korshun (reporter)
2017-07-14 21:58
edited on: 2017-07-14 22:01

 Really? That fixes the issue! Why did't you say so right away? I am releasing a patch for RGA2.
User avatar (0018034)
Ninjamander (reporter)
2017-07-15 04:02

 Guess they is no bug after all, on the bright side, this ticket was not totally pointless it seem!

Issue Community Support
This issue is already marked as resolved.
If you feel that is not the case, please reopen it and explain why.
Supporters: Korshun KirovNoir
Opponents: No one explicitly opposes this issue yet.

- Issue History
Date Modified Username Field Change
2017-07-14 00:20 Ninjamander New Issue
2017-07-14 06:00 Torr Samaho Note Added: 0018022
2017-07-14 06:01 Torr Samaho Status new => feedback
2017-07-14 13:09 Korshun Note Added: 0018023
2017-07-14 13:10 Korshun Note Edited: 0018023 View Revisions
2017-07-14 13:11 Korshun Note Edited: 0018023 View Revisions
2017-07-14 19:12 jdagenet Note Added: 0018028
2017-07-14 21:16 Korshun Note Added: 0018029
2017-07-14 21:17 Korshun Note Edited: 0018029 View Revisions
2017-07-14 21:39 jdagenet Note Added: 0018030
2017-07-14 21:41 jdagenet Note Edited: 0018030 View Revisions
2017-07-14 21:58 Korshun Note Added: 0018032
2017-07-14 22:01 Korshun Note Edited: 0018032 View Revisions
2017-07-15 04:02 Ninjamander Note Added: 0018034
2017-07-15 04:02 Ninjamander Status feedback => new
2017-07-15 08:42 Dusk Status new => resolved
2017-07-15 08:42 Dusk Resolution open => no change required
2018-09-30 22:33 Blzut3 Status resolved => closed




Questions or other issues? Contact Us.

Links

Copyright © 2000 - 2024 MantisBT Team
Powered by Mantis Bugtracker