0002840: A_Jump(256, ...) misprediction - MantisBT

Zandronum

Chat on our Discord Server Get the latest version: 3.1
Source Code

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

ID

Project

Category

View Status

Date Submitted

Last Update

0002840

Zandronum

[All Projects] Bug

public

2016-09-22 17:43

2024-03-01 20:53

Reporter

Ivan

Assigned To

Torr Samaho

Priority

normal

Severity

minor

Reproducibility

always

Status

assigned

Resolution

open

Platform

OS

OS Version

Product Version

2.1

Target Version

3.1

Fixed in Version

Summary

0002840: A_Jump(256, ...) misprediction

Description

A misprediction on the weapon below will cause it to seem like it fired thrice whereas it only fires twice. This appears in the form of the firing sound and the decals produced, but not ammo consumed or puffs spawned.

Steps To Reproduce

- Give Chaingun2
- Fire and move your mouse a bit, observe the decals, the fire sound etc.

Additional Information

Link:'https://www.dropbox.com/s/e44k08fos7ffiaq/ajumptest.pk3?dl=0 [^]'

ajumptest.pk3 [^] (376 bytes) 2016-09-22 20:02

A_Jump [^] (660 bytes) 2016-10-04 06:05 [Show Content] [Hide Content]

diff --git a/src/thingdef/thingdef_codeptr.cpp b/src/thingdef/thingdef_codeptr.cpp
--- a/src/thingdef/thingdef_codeptr.cpp
+++ b/src/thingdef/thingdef_codeptr.cpp
@@ -702,4 +702,10 @@
 	if ( NETWORK_InClientMode() )
 	{
 		if (( self->ulNetworkFlags & NETFL_CLIENTSIDEONLY ) == false )
+		{
+			if ( ( self->player != NULL )
+				&& ( ( CallingState == self->player->psprites[ps_weapon].state ) || ( CallingState == self->player->psprites[ps_flash].state ) ) )
+			{
+				P_SetPsprite (self->player, ps_weapon, CallingState, true);
+			}
 			return;
@@ -705,4 +711,5 @@
 			return;
+		}
 	}
 
 	if (count >= 2 && (maxchance >= 256 || pr_cajump() < maxchance))

Relationships

parent of	0002955	feedback		Run For It! does not work properly online in 161030-2038 build.
parent of	0002852	new		The experimental A_Jump(256, ...) handling causes problem in weapon
parent of	0002682	new		Enemy set translucent never becomes opaque again, but only in netplay
Not all the children of this issue are yet resolved or closed.

Notes
(0015697) Torr Samaho (administrator) 2016-09-24 11:57	Can you check if this works any better? If it does, can you also create a test case where A_Jump is used by a monster? This will require a different fix.

(0015698) Ivan (reporter) 2016-09-24 16:02	The provided example wad works, but I get a crash at startup with this build when running DnD, as soon as I connect to a local server it crashes. Here's the crash report:'https://www.dropbox.com/s/uitpd1bdwfta6nh/CrashReport.zip?dl=0 [^]'

(0015702) Torr Samaho (administrator) 2016-09-25 15:02 edited on: 2016-09-25 15:02	Please check if this fixes the crash.

(0015705) Ivan (reporter) 2016-09-25 20:39	That build fixes the crash.

(0015746) Edward-san (developer) 2016-10-03 22:28	Was this commited in zan's repository or not? At a first glance I found nothing in the commit history.

(0015749) Torr Samaho (administrator) 2016-10-04 06:05	No, I didn't commit this yet, since it's still very experimental. I'll attach the patch here and could also upload it to the sandbox later.

(0016980) Torr Samaho (administrator) 2017-03-12 19:56	For the record, the problem already happens in 2.1.2.

(0020029) Ivan (reporter) 2018-10-08 20:52	Does this feature exist in the current 3.1 build here'https://zandronum.com/forum/viewtopic.php?f=55&t=9340 [^]' so we can test, or not?

**Issue Community Support**
Only registered users can voice their support. Click here to register, or here to log in.
Supporters:	Fastclick Combinebobnt
Opponents:	No one explicitly opposes this issue yet.

Issue History
Date Modified	Username	Field	Change
2016-09-22 17:43	Ivan	New Issue
2016-09-22 20:02	Torr Samaho	File Added: ajumptest.pk3
2016-09-24 11:57	Torr Samaho	Note Added: 0015697
2016-09-24 11:57	Torr Samaho	Assigned To	=> Torr Samaho
2016-09-24 11:57	Torr Samaho	Status	new => needs testing
2016-09-24 16:02	Ivan	Note Added: 0015698
2016-09-25 15:02	Torr Samaho	Note Added: 0015702
2016-09-25 15:02	Torr Samaho	Note Edited: 0015702	View Revisions
2016-09-25 20:39	Ivan	Note Added: 0015705
2016-10-03 22:28	Edward-san	Note Added: 0015746
2016-10-04 06:05	Torr Samaho	Note Added: 0015749
2016-10-04 06:05	Torr Samaho	File Added: A_Jump
2016-12-24 22:42	Dusk	Target Version	=> 3.0
2017-02-06 19:01	Dusk	Status	needs testing => assigned
2017-03-12 19:56	Torr Samaho	Note Added: 0016980
2017-03-12 19:56	Torr Samaho	Product Version	3.0-beta => 2.1
2017-03-12 20:03	Torr Samaho	Target Version	3.0 => 3.1
2018-10-08 20:52	Ivan	Note Added: 0020029
2024-03-01 16:36	Ru5tK1ng	Relationship added	parent of 0002955
2024-03-01 20:38	Ru5tK1ng	Relationship added	parent of 0002852
2024-03-01 20:53	Ru5tK1ng	Relationship added	parent of 0002682

Questions or other issues? Contact Us.

Links

Copyright © 2012-2024, Torr Samaho & Zandronum Team.

Doom and Doom II are the property of id Software.

Copyright © 2000 - 2024 MantisBT Team