Anonymous | Login | Signup for a new account | 2024-05-03 01:26 UTC |
My View | View Issues | Change Log | Roadmap | Zandronum Issue Support Ranking | Rules | My Account |
View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
0002361 | Zandronum | [All Projects] Bug | public | 2015-07-26 01:05 | 2024-03-07 18:32 | ||||
Reporter | Ru5tK1ng | ||||||||
Assigned To | |||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Platform | Microsoft | OS | Windows | OS Version | XP/Vista/7 | ||||
Product Version | 2.1 | ||||||||
Target Version | 3.2 | Fixed in Version | 3.2 | ||||||
Summary | 0002361: Floatbob items respawn incorrectly after Duel Countdown | ||||||||
Description | This occurs both online and offline. If you have an item with the floatbob property on a floor below or above 0 height, the item will appear higher or lower than it should be after the duel countdown resets the map. If item respawn is on then item will respawn at the correct height. I have attached a test map that illustrates this. | ||||||||
Steps To Reproduce | 1. Download floattest.wad 2. Start on map01 and observe the float behavior 3. Make sure the mode is in duel and the duel countdown is greater than 1 4. add a bot 5. After the countdown resets the map, the floating is now incorrect 6. Spectate and rejoin if nothing changes | ||||||||
Attached Files | floattest.wad [^] (3,562 bytes) 2015-07-26 01:05 floatbob.diff [^] (2,842 bytes) 2024-01-05 02:39 [Show Content] floattestv2.wad [^] (6,316 bytes) 2024-03-03 06:43 | ||||||||
Notes | |
(0013004) Dusk (developer) 2015-07-26 01:26 |
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/138 [^]' |
(0013007) WaTaKiD (updater) 2015-07-26 07:56 |
this build contains the above commit:'https://www.dropbox.com/s/ly8ias3ko9s4388/zandronum-2.1.2-r150726-0121-5069de9-windows.zip?dl=0 [^]' |
(0013008) Ru5tK1ng (updater) 2015-07-26 20:35 |
I tested the build locally and on a LAN server. The floating items didn't desync or float incorrectly at all. |
(0013011) Dusk (developer) 2015-07-27 17:08 |
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-request/1 [^]' |
(0015663) Ru5tK1ng (updater) 2016-09-19 01:34 |
I read the comments on that pull request and I tried for a good while to try to invoke the code that follows this if statement: // If this object belongs to someone's inventory, and it originally spawned on the // level, respawn the item in its original location, but don't take it out of the // player's inventory. if (( pActor->IsKindOf( RUNTIME_CLASS( AInventory ))) && ( static_cast<AInventory *>( pActor )->Owner )) All floatbob items lived through countdowns, resets, ACS Resets, offline, online, custom inventory items, heretic timebomb, on floors, on 3d floors, z-height or no z-height, item respawn off or on. I would say it's safe to say that single change is all that's needed to fix the bug. If someone devises a case where bobbing breaks with the fix, we at least already know what to change. |
(0017787) Combinebobnt (reporter) 2017-05-29 02:38 |
affected old eon weapons and cyberrunner. all the items float at one height level in the map |
(0022971) Ru5tK1ng (updater) 2024-01-05 02:43 |
I uploaded a patch that fixes this issue and the awkward clipping behavior with gl_spriteclip 0. |
(0022973) Torr Samaho (administrator) 2024-01-07 20:26 |
Part of this patch is in GZDoom code. So this sounds like this is a GZDoom. Is it? If so, did GZDoom fix this? |
(0022975) Kaminsky (developer) 2024-01-07 21:38 |
Ru5tK1ng: Hello, in regards to 2361, gzdoom did fix hexen floatbob clipping but way ahead in version 4.5.0 Torr Samaho: Ok, so that sounds like the GZDoom fix is way too far off to backport and considering our own fix should be fine. The patch ("floatbob.diff") attached to this ticket was pushed into the repository:'https://foss.heptapod.net/zandronum/zandronum-stable/-/commit/17757ad8e820f40edf930d64f27b5641c62d1fa6 [^]' |
(0023287) Ru5tK1ng (updater) 2024-03-03 06:43 |
Mostly fixed from testing. Just needs 1 last adjustment: 'https://foss.heptapod.net/zandronum/zandronum-stable/-/merge_requests/39 [^]' |
(0023294) Ru5tK1ng (updater) 2024-03-03 17:25 |
Change was merged in |
(0023313) Ru5tK1ng (updater) 2024-03-07 18:32 |
Pulled the latest changes and this bug can finally be put to rest. |
This issue is already marked as resolved. If you feel that is not the case, please reopen it and explain why. |
|
Supporters: | Combinebobnt Ru5tK1ng |
Opponents: | No one explicitly opposes this issue yet. |
Issue History | |||
Date Modified | Username | Field | Change |
2015-07-26 01:05 | Ru5tK1ng | New Issue | |
2015-07-26 01:05 | Ru5tK1ng | File Added: floattest.wad | |
2015-07-26 01:26 | Dusk | Note Added: 0013004 | |
2015-07-26 01:26 | Dusk | Assigned To | => Dusk |
2015-07-26 01:26 | Dusk | Status | new => needs review |
2015-07-26 01:27 | Dusk | Summary | Floatbob Desyncs after Duel Countdown => Floatbob items respawn incorrectly after Duel Countdown |
2015-07-26 07:56 | WaTaKiD | Note Added: 0013007 | |
2015-07-26 20:35 | Ru5tK1ng | Note Added: 0013008 | |
2015-07-27 17:08 | Dusk | Note Added: 0013011 | |
2016-09-19 01:34 | Ru5tK1ng | Note Added: 0015663 | |
2017-05-29 02:38 | Combinebobnt | Note Added: 0017787 | |
2023-05-15 13:35 | DrinkyBird | Note Added: 0022845 | |
2023-05-15 13:35 | DrinkyBird | Assigned To | Dusk => DrinkyBird |
2023-05-15 13:35 | DrinkyBird | Target Version | => 3.2 |
2023-06-13 23:04 | DrinkyBird | Assigned To | DrinkyBird => |
2023-06-13 23:04 | DrinkyBird | Status | needs review => confirmed |
2023-06-13 23:04 | DrinkyBird | Note Deleted: 0022845 | |
2024-01-05 02:39 | Ru5tK1ng | File Added: floatbob.diff | |
2024-01-05 02:43 | Ru5tK1ng | Note Added: 0022971 | |
2024-01-05 02:46 | Ru5tK1ng | Status | confirmed => needs review |
2024-01-07 20:26 | Torr Samaho | Note Added: 0022973 | |
2024-01-07 21:38 | Kaminsky | Note Added: 0022975 | |
2024-01-07 21:38 | Kaminsky | Status | needs review => needs testing |
2024-03-03 06:43 | Ru5tK1ng | Note Added: 0023287 | |
2024-03-03 06:43 | Ru5tK1ng | Status | needs testing => needs review |
2024-03-03 06:43 | Ru5tK1ng | File Added: floattestv2.wad | |
2024-03-03 17:25 | Ru5tK1ng | Note Added: 0023294 | |
2024-03-03 17:25 | Ru5tK1ng | Status | needs review => needs testing |
2024-03-07 18:32 | Ru5tK1ng | Note Added: 0023313 | |
2024-03-07 18:32 | Ru5tK1ng | Status | needs testing => resolved |
2024-03-07 18:32 | Ru5tK1ng | Resolution | open => fixed |
2024-03-07 18:32 | Ru5tK1ng | Fixed in Version | => 3.2 |
Copyright © 2000 - 2024 MantisBT Team |