MantisBT - Zandronum
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0003016Zandronum[All Projects] Bugpublic2017-02-17 02:062018-09-30 21:46
ReporterStrikerMan780 
Assigned ToTorr Samaho 
PriorityhighSeverityblockReproducibilityalways
StatusclosedResolutionfixed 
PlatformMicrosoftOSWindowsOS VersionXP/Vista/7
Product Version3.0-beta 
Target Version3.0Fixed in Version3.0 
Summary0003016: GAMEINFO auto-loaded PWADs load twice if joining through Doomseeker or Doom Explorer
DescriptionIf a PWAD contains a GAMEINFO lump, and requests other wads get loaded with it, they will get loaded twice if someone joins through Doomseeker or Doom Explorer.
Steps To ReproduceGet skulltag_data_fixed.pk3:'http://www.wad-archive.com/wad/048122af1c22cb7b146ad76a20bd5dca [^]'

Put it in the same folder as Zandronum.exe

Then, get the attached GAMEINFO.PK3, stick it in there too.

Launch a server with zandronum.exe -host -file GAMEINFO.PK3

It'll automatically pull in skulltag_data_fixed.pk3.

Now, join the server with Doom Explorer or Doomseeker. The WAD will be loaded twice, and the game will crash.
Additional Information
TagsNo tags attached.
Relationships
Attached Files? GAMEINFO.PK3 (282) 2017-02-17 02:06
https://zandronum.com/tracker/file_download.php?file_id=2028&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-02-17 02:06StrikerMan780New Issue
2017-02-17 02:06StrikerMan780File Added: GAMEINFO.PK3
2017-02-17 02:08StrikerMan780Note Added: 0016871
2017-02-17 02:09StrikerMan780Note Edited: 0016871bug_revision_view_page.php?bugnote_id=16871#r10197
2017-02-17 02:09StrikerMan780Note Edited: 0016871bug_revision_view_page.php?bugnote_id=16871#r10198
2017-02-27 13:26Torr SamahoNote Added: 0016915
2017-02-27 13:27Torr SamahoStatusnew => feedback
2017-02-27 17:13StrikerMan780Note Added: 0016916
2017-02-27 17:13StrikerMan780Statusfeedback => new
2017-02-27 17:17StrikerMan780Note Edited: 0016916bug_revision_view_page.php?bugnote_id=16916#r10223
2017-02-27 17:18StrikerMan780Note Edited: 0016916bug_revision_view_page.php?bugnote_id=16916#r10224
2017-02-27 17:18StrikerMan780Note Edited: 0016916bug_revision_view_page.php?bugnote_id=16916#r10225
2017-02-27 17:19StrikerMan780Note Edited: 0016916bug_revision_view_page.php?bugnote_id=16916#r10226
2017-02-27 17:22StrikerMan780Note Edited: 0016916bug_revision_view_page.php?bugnote_id=16916#r10227
2017-03-03 07:00Torr SamahoNote Added: 0016926
2017-03-03 07:01Torr SamahoAssigned To => Torr Samaho
2017-03-03 07:01Torr SamahoStatusnew => feedback
2017-03-05 14:55Torr SamahoNote Added: 0016931
2017-03-05 14:56Torr SamahoStatusfeedback => needs testing
2017-03-05 14:56Torr SamahoTarget Version => 3.0
2017-04-19 01:27CombinebobntNote Added: 0017210
2017-04-19 01:35StrikerMan780Note Added: 0017211
2017-04-27 01:44Ru5tK1ngStatusneeds testing => resolved
2017-04-27 01:44Ru5tK1ngResolutionopen => fixed
2017-04-27 01:44Ru5tK1ngFixed in Version => 3.0
2018-09-30 21:46Blzut3Statusresolved => closed

Notes
(0016871)
StrikerMan780   
2017-02-17 02:08   
(edited on: 2017-02-17 02:09)
I suggest making Zandronum not pull WADs/PK3s from the LOAD line of GAMEINFO if said WAD/PK3 was already loaded via the command line.
(0016915)
Torr Samaho   
2017-02-27 13:26   
I can easily flag the files loaded by GAMEINFO as automatically loaded, so that they won't appear on the list of pwads reported to the launcher. Unfortunately, this way the launcher doesn't know that the client needs the wad to join.

Quote from StrikerMan780

I suggest making Zandronum not pull WADs/PK3s from the LOAD line of GAMEINFO if said WAD/PK3 was already loaded via the command line.

This sounds like something GZDoom should do. Does the latest GZDoom already do this by any chance? Nevertheless, won't this change the order in which the files are loaded?
(0016916)
StrikerMan780   
2017-02-27 17:13   
(edited on: 2017-02-27 17:22)
EDIT: Just realized it wouldn't change the load order, because Zandronum already sends the loaded wads to the master server in the same order the server does. (They always load just before the WAD with the GAMEINFO lump.)

Also, GZDoom has this issue as well, just tested it. It will double-load files.
(0016926)
Torr Samaho   
2017-03-03 07:00   
I thought a bit more about this and think the best would be to simply have the client (in the sense of a binary started with "-connect") not load the wads specified in GAMEINFO. The server already added those in the correct order to the list of files advertised to the launcher, so the launcher will add all necessary files to the command that starts the client.
(0016931)
Torr Samaho   
2017-03-05 14:55   
Should be fixed now using the approach from 0003016:0016926.
(0017210)
Combinebobnt   
2017-04-19 01:27   
r170416-0710 it worked
(0017211)
StrikerMan780   
2017-04-19 01:35   
Nice. Thank you.