MantisBT - Zandronum |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0002598 | Zandronum | [All Projects] Bug | public | 2016-01-27 08:47 | 2018-09-30 21:40 |
|
Reporter | throwaway | |
Assigned To | Dusk | |
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | | OS Version | |
Product Version | 2.1 | |
Target Version | 2.2 | Fixed in Version | 2.2 | |
|
Summary | 0002598: ACS_ExecuteAlways from server to client corrupts negative arguments |
Description | When running ACS_ExecuteAlways on a clientside script from the server, any argument from -1 to -128 gets corrupted to 256+<value>. Anything positive, or lower than -128, is unaffected. |
Steps To Reproduce | 1. Host test.pk3.
2. Join server hosting test.pk3.
3. 'puke 1'
4. It should print -1, but prints 255 instead. |
Additional Information | |
Tags | No tags attached. |
Relationships | |
Attached Files | test.pk3 (8,029) 2016-01-27 08:47 https://zandronum.com/tracker/file_download.php?file_id=1715&type=bug |
|
Issue History |
Date Modified | Username | Field | Change |
2016-01-27 08:47 | throwaway | New Issue | |
2016-01-27 08:47 | throwaway | File Added: test.pk3 | |
2016-01-29 18:57 | cruduxy | Note Added: 0014225 | |
2016-01-29 20:49 | Dusk | Note Added: 0014228 | |
2016-01-29 20:49 | Dusk | Assigned To | => Dusk |
2016-01-29 20:49 | Dusk | Status | new => assigned |
2016-01-29 21:04 | throwaway | Note Added: 0014230 | |
2016-01-29 21:10 | Dusk | Note Added: 0014232 | |
2016-01-29 21:10 | Dusk | Status | assigned => needs review |
2016-01-29 21:12 | Dusk | Note Edited: 0014232 | bug_revision_view_page.php?bugnote_id=14232#r8594 |
2016-01-29 22:35 | throwaway | Note Added: 0014233 | |
2016-01-30 13:48 | cobalt | Status | needs review => needs testing |
2016-01-30 13:48 | cobalt | Target Version | => 2.2 |
2016-01-30 13:48 | cobalt | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=8597#r8597 |
2016-01-30 13:48 | cobalt | Note Added: 0014241 | |
2016-01-30 13:48 | Dusk | Status | needs testing => resolved |
2016-01-30 13:48 | Dusk | Fixed in Version | => 2.2 |
2016-01-30 13:48 | Dusk | Resolution | open => fixed |
2018-09-30 21:40 | Blzut3 | Status | resolved => closed |
Notes |
|
|
Running client-sided scripts on the servers is the biggest problem here. The server should just print -Warning : DO NOT USE CLIENT SIDED SCRIPTS SERVER SIDE- |
|
|
(0014228)
|
Dusk
|
2016-01-29 20:49
|
|
Hmm how did this manage to break? Oh well...
Quote Running client-sided scripts on the servers is the biggest problem here. The server should just print -Warning : DO NOT USE CLIENT SIDED SCRIPTS SERVER SIDE-
Nonsense. |
|
|
|
The clientside script is not running on the server, as Print(d:ConsolePlayerNumber()) would confirm. Only ACS_ExecuteWithResult can get the server to run clientside scripts itself, and this is using ACS_ExecuteAlways. |
|
|
(0014232)
|
Dusk
|
2016-01-29 21:10
(edited on: 2016-01-29 21:12) |
|
'https://bitbucket.org/Torr_Samaho/zandronum-stable/pull-requests/23 [^]'
Quote
Only ACS_ExecuteWithResult can get the server to run clientside scripts itself, and this is using ACS_ExecuteAlways.
This sounds like a bug. Though of course the server cannot get the result back from the client (fast enough anyway, the server would freeze until the answer is back), the server shouldn't in any circumstance run CLIENTSIDE scripts.
|
|
|
|
|
|
(0014241)
|
cobalt
|
2016-01-30 13:48
|
|
|